Introduce show_danger #4404
Merged
Introduce show_danger #4404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
8 tasks
ibz
force-pushed
the
ibz/20241128-danger
branch
from
135f9b0 to
d8d236e
Compare
ibz
force-pushed
the
ibz/20241128-danger
branch
from
d8d236e to
cba2e08
Compare
obrusvit
reviewed
Nov 29, 2024
obrusvit
approved these changes
Nov 29, 2024
|
Why did the exclamation mark disappear from the "Warning" header. Why did the text change from "cancel and exit" to "cancel"? |
For consistency. Now all of these warnings look the same. If you think they should all have the exclamation mark, I can add that. But the ETH contract design did not have it.
Where? |
|
Strange, I was looking at the diff this morning and it was like that. Also "important" had an exclamation mark, but "Warning" did not. Now everything is fine. Thank you. |
matejcik
approved these changes
Dec 2, 2024
ibz
force-pushed
the
ibz/20241128-danger
branch
from
bbcaeb0 to
7873a24
Compare
obrusvit
force-pushed
the
ibz/20241128-danger
branch
from
7873a24 to
b249ad4
Compare
obrusvit
added
the
translations
This is a unified interface for flow_warning_hi_prio, which was available only on Mercury before. [no changelog]
obrusvit
force-pushed
the
ibz/20241128-danger
branch
from
b249ad4 to
7765931
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a unified interface for
flow_warning_hi_prio, which was available only on Mercury before.